Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-menu): implement increasing elevation #22506

Merged
merged 1 commit into from May 3, 2021
Merged

fix(material-experimental/mdc-menu): implement increasing elevation #22506

merged 1 commit into from May 3, 2021

Conversation

crisbeto
Copy link
Member

Previously we didn't implement the feature where nested menus increase their elevation for each level, because we didn't have elevation classes based on MDC. Now that we do, we can implement the feature.

Also adds an extra elevation class that allows us to increase the specificity over the default one from MDC.

@crisbeto
fix(material-experimental/mdc-menu): implement increasing elevation
aff5253 
Previously we didn't implement the feature where nested menus increase their elevation for each level, because we didn't have elevation classes based on MDC. Now that we do, we can implement the feature.

Also adds an extra elevation class that allows us to increase the specificity over the default one from MDC.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Apr 18, 2021
@crisbeto crisbeto requested a review from mmalerba April 18, 2021 09:43
@crisbeto crisbeto requested a review from a team as a code owner April 18, 2021 09:43
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 18, 2021
mmalerba
mmalerba approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Apr 26, 2021
@josephperrott josephperrott requested review from devversion and removed request for a team April 29, 2021 15:57
@annieyw annieyw merged commit 8ef4a77 into angular:master May 3, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @mmalerba @annieyw