Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-form-field): error with latest canary version #22623

Merged
merged 1 commit into from May 4, 2021
Merged

fix(material-experimental/mdc-form-field): error with latest canary version #22623

merged 1 commit into from May 4, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 3, 2021

Fixes an error in the latest canary version, because we were passing undefined to a method that was expecting a number.

@crisbeto
fix(material-experimental/mdc-form-field): error with latest canary v…
5e2c0be 
…ersion

Fixes an error in the latest canary version, because we were passing `undefined` to a method that was expecting a number.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate labels May 3, 2021
@crisbeto crisbeto requested a review from devversion May 3, 2021 19:31
@crisbeto crisbeto requested review from mmalerba and a team as code owners May 3, 2021 19:31
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 3, 2021
@crisbeto crisbeto requested a review from annieyw May 3, 2021 19:31
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 3, 2021
@crisbeto crisbeto mentioned this pull request May 4, 2021
Merged
@annieyw annieyw added target: minor This PR is targeted for the next minor release and removed target: rc This PR is targeted for the next release-candidate labels May 4, 2021
@annieyw annieyw merged commit cabb9ce into angular:master May 4, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@annieyw annieyw annieyw approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @devversion @annieyw