Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/sort): fix undefined object access #22634

Merged
merged 1 commit into from May 19, 2021

Conversation

chunghha
Copy link
Contributor

@chunghha chunghha commented May 6, 2021

This commit fixes hard crash that results from accessing undefined object's property. #22210

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 6, 2021
@chunghha
Copy link
Contributor Author

chunghha commented May 6, 2021

@crisbeto and @andrewseguin please review.

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels May 6, 2021
@swftvsn
Copy link
Contributor

swftvsn commented May 10, 2021

Awesome!

Thank you for the work!

@aailyin
Copy link

aailyin commented May 13, 2021

@andrewseguin Could you move forward this PR, please? It would be awesome to have this fix in the nearest release..

@chunghha
Copy link
Contributor Author

@andrewseguin / @crisbeto could we get this fix merged to resolve the production bug with v11.2.x if a release will happen today for the version? Othewise, I'd like to be communicated about when to be merged if this fix is going to stay still in the queue today.

@andrewseguin andrewseguin merged commit 68600b8 into angular:master May 19, 2021
andrewseguin pushed a commit that referenced this pull request May 19, 2021
@andrewseguin
Copy link
Contributor

I was able to get this merged in but unfortunately it won't be backported to the 11.2.x branch. The fix will be present in the next 12.0.x patch released today

@chunghha
Copy link
Contributor Author

Thanks, @andrewseguin

However, I can upgrade my production apps to Angular v12 about 6 months later. Is there any particular reason not to patch the error in the 11.2.x? I mean it would be so nice to get it backported to the branch. If you want me to check out the 11.2.x branch then I will do a PR with the branch. Please let me know.

chunghha added a commit to chunghha/components that referenced this pull request May 19, 2021
This is to backport the commit angular#22634 to 11.2.x branch.
@chunghha
Copy link
Contributor Author

I just saw the changelog of 11.2.13 in the branch. Thanks a lot, @andrewseguin

@andrewseguin
Copy link
Contributor

You got it @chunghha, hope that helps y'all out!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants