New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/sort): fix undefined object access #22634
Conversation
@crisbeto and @andrewseguin please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Awesome! Thank you for the work! |
@andrewseguin Could you move forward this PR, please? It would be awesome to have this fix in the nearest release.. |
@andrewseguin / @crisbeto could we get this fix merged to resolve the production bug with v11.2.x if a release will happen today for the version? Othewise, I'd like to be communicated about when to be merged if this fix is going to stay still in the queue today. |
(cherry picked from commit 68600b8)
I was able to get this merged in but unfortunately it won't be backported to the 11.2.x branch. The fix will be present in the next 12.0.x patch released today |
Thanks, @andrewseguin However, I can upgrade my production apps to Angular v12 about 6 months later. Is there any particular reason not to patch the error in the 11.2.x? I mean it would be so nice to get it backported to the branch. If you want me to check out the 11.2.x branch then I will do a PR with the branch. Please let me know. |
This is to backport the commit angular#22634 to 11.2.x branch.
I just saw the changelog of 11.2.13 in the branch. Thanks a lot, @andrewseguin |
You got it @chunghha, hope that helps y'all out! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit fixes hard crash that results from accessing undefined object's property. #22210