Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multiple): add ng-update entry for google-maps and youtube-player package #22710

Merged
merged 1 commit into from May 19, 2021

Conversation

devversion
Copy link
Member

Currently if developers run ng update without specifying a package,
the CLI will analyze the current workspace and find packages that
provide migrations and need to be updated. For the youtube-player
and google-maps package we do not provide any migrations, so
ng update will not report this package.

Since these packages are part of the @angular scope, we
want these packages to be highlighted when users run ng update.
There aren't any migrations for these packages yet, but we are setting
up the integration with ng update in order to make these packages
visible to the CLI.

Fixes #22689.

…ayer` package

Currently if developers run `ng update` without specifying a package,
the CLI will analyze the current workspace and find packages that
provide migrations and need to be updated. For the `youtube-player`
and `google-maps` package we do not provide any migrations, so
`ng update` will not report this package.

Since these packages are part of the `@angular` scope, we
want these packages to be highlighted when users run `ng update`.
There aren't any migrations for these packages yet, but we are setting
up the integration with `ng update` in order to make these packages
visible to the CLI.

Fixes angular#22689.
@devversion devversion added merge safe target: minor This PR is targeted for the next minor release area: ng-update Issues related to `ng-update` integration labels May 17, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 17, 2021
@devversion
Copy link
Member Author

@jelbourn This brings up the question: How to implement update migrations (if any needed in the future) if we don't have a dependency on the CDK for these packages. The CDK currently provides the common utilities for writing update schematics.

@Splaktar
Copy link
Member

@devversion it almost seems like we need a separate @angular/schematic-tools repository for storing these common utilities 😉

Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would certainly be expected for these packages to show up in the output of ng update if they are out of date.

@devversion
Copy link
Member Author

@devversion it almost seems like we need a separate @angular/schematic-tools repository for storing these common utilities 😉

Oh yeah 😄 I've been wanting something like this for a long time. I've built a lot of tooling around ng-update here and in framework. It would be great to avoid duplication here.

IIRC the tooling team is currently evaluating which tools would be candidates for a common utility package. I'm not sure how well our ng update infrastructure would fit though.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label May 17, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit fb1d930 into angular:master May 19, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: ng-update Issues related to `ng-update` integration cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@angular/google-maps version isn't updated when running ng update
5 participants