New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multiple): add ng-update entry for google-maps
and youtube-player
package
#22710
Conversation
…ayer` package Currently if developers run `ng update` without specifying a package, the CLI will analyze the current workspace and find packages that provide migrations and need to be updated. For the `youtube-player` and `google-maps` package we do not provide any migrations, so `ng update` will not report this package. Since these packages are part of the `@angular` scope, we want these packages to be highlighted when users run `ng update`. There aren't any migrations for these packages yet, but we are setting up the integration with `ng update` in order to make these packages visible to the CLI. Fixes angular#22689.
@jelbourn This brings up the question: How to implement update migrations (if any needed in the future) if we don't have a dependency on the CDK for these packages. The CDK currently provides the common utilities for writing update schematics. |
@devversion it almost seems like we need a separate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It would certainly be expected for these packages to show up in the output of ng update
if they are out of date.
Oh yeah 😄 I've been wanting something like this for a long time. I've built a lot of tooling around ng-update here and in framework. It would be great to avoid duplication here. IIRC the tooling team is currently evaluating which tools would be candidates for a common utility package. I'm not sure how well our ng update infrastructure would fit though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently if developers run
ng update
without specifying a package,the CLI will analyze the current workspace and find packages that
provide migrations and need to be updated. For the
youtube-player
and
google-maps
package we do not provide any migrations, song update
will not report this package.Since these packages are part of the
@angular
scope, wewant these packages to be highlighted when users run
ng update
.There aren't any migrations for these packages yet, but we are setting
up the integration with
ng update
in order to make these packagesvisible to the CLI.
Fixes #22689.