fix(cdk/drag-drop): avoid conflicts with sticky table headers #22864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Material table with sticky headers sets its `position` as `!important` which ends up overriding the dragging styles. These changes rework the internals to use `setProperty` instead of `element.style.position` which allows us to set the `position` as `!important` as well. It also has the advantage that we can write the properties as dash case, instead of having to guess whether the vendor-prefixed properties are camel case or pascal case. Fixes angular#22781.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
|
Thank you for the quick fix on this @crisbeto! |
jelbourn
reviewed
Jun 21, 2021
Comment on lines
+91
to
+96
| /** Inline styles to be set as `!important` while dragging. */ | ||
| const dragImportantProperties = new Set([ | ||
| // Needs to be important, because some `mat-table` sets `position: sticky !important`. See #22781. | ||
| 'position' | ||
| ]); | ||
|
|
There was a problem hiding this comment.
How problematic would it be to alternatively remove the !important from mat-table? My inclination would be to avoid an !important arms race by avoiding it completely.
There was a problem hiding this comment.
The problem with removing the !important is that our sticky header selector currently has really low specificity and can be overwritten by styles that have been encapsulated by Angular. See #20558.
wagnermaciel
pushed a commit
that referenced
this pull request
Jul 9, 2021
The Material table with sticky headers sets its `position` as `!important` which ends up overriding the dragging styles. These changes rework the internals to use `setProperty` instead of `element.style.position` which allows us to set the `position` as `!important` as well. It also has the advantage that we can write the properties as dash case, instead of having to guess whether the vendor-prefixed properties are camel case or pascal case. Fixes #22781. (cherry picked from commit 6cfb549)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Material table with sticky headers sets its
positionas!importantwhich ends up overriding the dragging styles. These changes rework the internals to usesetPropertyinstead ofelement.style.positionwhich allows us to set thepositionas!importantas well. It also has the advantage that we can write the properties as dash case, instead of having to guess whether the vendor-prefixed properties are camel case or pascal case.Fixes #22781.