-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/core): Focus indicator theme and color mixins should accept a basic color as well. #23016
Conversation
185446d
to
8078cb9
Compare
…ept a basic color as well. fix(core/material): Disable styelint for focus indicator theme mixins.
8078cb9
to
ea090ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this should be considered a patch. Colors as an input was supported in 12.0, and is not supported in 12.1.x. I think this is an unintentional breaking change. |
@mmalerba was this changed to minor due to merge conflicts? |
…ept a basic color as well. (angular#23016) fix(core/material): Disable styelint for focus indicator theme mixins.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
As described in https://material.angular.io/guide/theming#customizing-strong-focus-indicators, the focus indicator theme and color mixins should allow the user to pass in a basic CSS color. This PR updates the mixins to allow this.
Alternatively, we could update the documentation to disallow this. I disabled the stylelint checks for these mixins because their new implementations aren't compatible with the checks.