Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(google-maps): throw an error if clustering library hasn't been loaded #23064

Merged
merged 1 commit into from
Jul 2, 2021
Merged

fix(google-maps): throw an error if clustering library hasn't been loaded #23064

merged 1 commit into from
Jul 2, 2021

Conversation

crisbeto
Copy link
Member

Clustering in the Google Maps module requires a separate library, but we never check it's actually been loaded. These changes add an error to make it easier to debug.

Relates to #23050.

@crisbeto
fix(google-maps): throw an error if clustering library hasn't been lo…
427bc61 
…aded

Clustering in the Google Maps module requires a separate library, but we never check it's actually been loaded. These changes add an error to make it easier to debug.

Relates to angular#23050.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 24, 2021
@crisbeto crisbeto requested a review from jelbourn June 24, 2021 20:43
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 24, 2021
jelbourn
jelbourn approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jun 30, 2021
@andrewseguin andrewseguin merged commit cd9f5eb into angular:master Jul 2, 2021
andrewseguin pushed a commit that referenced this pull request Jul 2, 2021
@crisbeto @andrewseguin
fix(google-maps): throw an error if clustering library hasn't been lo…
a601546 
…aded (#23064)

Clustering in the Google Maps module requires a separate library, but we never check it's actually been loaded. These changes add an error to make it easier to debug.

Relates to #23050.

(cherry picked from commit cd9f5eb)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @jelbourn @andrewseguin