-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material-experimental/mdc-tooltip): make background color opaque #23106
Merged
wagnermaciel
merged 3 commits into
angular:master
from
wagnermaciel:mdc-tooltip-background-color-opacity
Jul 13, 2021
Merged
fix(material-experimental/mdc-tooltip): make background color opaque #23106
wagnermaciel
merged 3 commits into
angular:master
from
wagnermaciel:mdc-tooltip-background-color-opacity
Jul 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* due to a11y concerns surrounding the 0.6 background color opacity of the mdc-tooltip, we are switching to using our own custom background color instead of the one defined in the MDC styles.
google-cla
bot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Jul 2, 2021
crisbeto
reviewed
Jul 2, 2021
jelbourn
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jelbourn
added
Accessibility
This issue is related to accessibility (a11y)
action: merge
The PR is ready for merge by the caretaker
target: patch
This PR is targeted for the next patch release
P2
The issue is important to a large percentage of users, with a workaround
labels
Jul 2, 2021
crisbeto
reviewed
Jul 2, 2021
wagnermaciel
added a commit
that referenced
this pull request
Jul 13, 2021
…23106) * fix(material-experimental/mdc-tooltip): make background color opaque * due to a11y concerns surrounding the 0.6 background color opacity of the mdc-tooltip, we are switching to using our own custom background color instead of the one defined in the MDC styles. * fixup! fix(material-experimental/mdc-tooltip): make background color opaque * fixup! fix(material-experimental/mdc-tooltip): make background color opaque (cherry picked from commit e134598)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Accessibility
This issue is related to accessibility (a11y)
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
P2
The issue is important to a large percentage of users, with a workaround
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdc-tooltip, we are switching to using our own custom background color
instead of the one defined in the MDC styles.