Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/drag-drop): don't start dragging on fake screen reader events #23126

Merged
merged 1 commit into from
Jul 12, 2021
Merged

fix(cdk/drag-drop): don't start dragging on fake screen reader events #23126

merged 1 commit into from
Jul 12, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 7, 2021

Fixes that the CDK drag&drop could be triggered by fake mousedown or touchstart events dispatched by a screen reader.

@crisbeto
fix(cdk/drag-drop): don't start dragging on fake screen reader events
dc90615 
Fixes that the CDK drag&drop could be triggered by fake `mousedown` or `touchstart` events dispatched by a screen reader.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 7, 2021
@crisbeto crisbeto requested a review from jelbourn July 7, 2021 05:22
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 7, 2021
jelbourn
jelbourn approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 7, 2021
@wagnermaciel wagnermaciel merged commit 88d68ff into angular:master Jul 12, 2021
wagnermaciel pushed a commit that referenced this pull request Jul 12, 2021
@crisbeto @wagnermaciel
fix(cdk/drag-drop): don't start dragging on fake screen reader events (…
1463338 
…#23126)

Fixes that the CDK drag&drop could be triggered by fake `mousedown` or `touchstart` events dispatched by a screen reader.

(cherry picked from commit 88d68ff)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @jelbourn @wagnermaciel