fix(material-experimental/mdc-list): fix secondary line accidentally wrapping text #23236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrapping text MDC currently supports three-line list items in a way where they assume that the second list line should wrap into a third line. This is not suitable for our MDC-based list because it would result in an incompatibility with the non-MDC list and as per Material Design spec it is a supported case to have a third list line that is decoupled from the second line. The spec describes multiple variants for a three-line list, and MDC is not off the spec here, but just doesn't support our three-line list variant yet. It is planned to continue discussion with the MDC team to push forward on the other three-line variants.
devversion
added
P2
google-cla
bot
added
the
cla: yes
mmalerba
pushed a commit
that referenced
this pull request
Jul 27, 2021
…wrapping text (#23236) MDC currently supports three-line list items in a way where they assume that the second list line should wrap into a third line. This is not suitable for our MDC-based list because it would result in an incompatibility with the non-MDC list and as per Material Design spec it is a supported case to have a third list line that is decoupled from the second line. The spec describes multiple variants for a three-line list, and MDC is not off the spec here, but just doesn't support our three-line list variant yet. It is planned to continue discussion with the MDC team to push forward on the other three-line variants. (cherry picked from commit 74d08cf)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDC currently supports three-line list items in a way where
they assume that the second list line should wrap into
a third line. This is not suitable for our MDC-based list
because it would result in an incompatibility with the non-MDC
list and as per Material Design spec it is a supported case
to have a third list line that is decoupled from the second line.
The spec describes multiple variants for a three-line list, and
MDC is not off the spec here, but just doesn't support our
three-line list variant yet. It is planned to continue discussion
with the MDC team to push forward on the other three-line variants.
Note for team: I've added a new item to the agenda. I've been chatting
with Brandon from the MDC a little about this. They are open in supporting
the variant we need for our MDC-based list, but are looking for arguments
in order to prioritize the variant we need.