Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slider): vertical slider #26695

Closed
oleal opened this issue Feb 26, 2023 · 5 comments
Closed

feat(slider): vertical slider #26695

oleal opened this issue Feb 26, 2023 · 5 comments
Labels
area: material/slider feature This issue represents a new feature or feature request rather than a bug or bug fix needs: discussion Further discussion with the team is needed before proceeding P4 A relatively minor issue that is not relevant to core functions

Comments

@oleal
Copy link

oleal commented Feb 26, 2023

Feature Description

slider seems to be only horizontal

for material for angular js, a "vertical" property existed for mat-slider

Use Case

chose orientation for mat-slider

@oleal oleal added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Feb 26, 2023
@wagnermaciel wagnermaciel added area: material/slider P4 A relatively minor issue that is not relevant to core functions and removed needs triage This issue needs to be triaged by the team labels Feb 27, 2023
@sorozco2
Copy link

Any update on this feature?

@bgomes-bacardi
Copy link

Given that

image

The legacyslider will be deprecated this priority should be higher? @wagnermaciel

@wagnermaciel
Copy link
Contributor

@jelbourn Is this still a feature we are considering adding?

@wagnermaciel wagnermaciel added the needs: discussion Further discussion with the team is needed before proceeding label Aug 26, 2023
@wagnermaciel
Copy link
Contributor

I discussed this with the team and the unfortunate conclusion is that this is not something we plan on implementing

Context

The new mdc-based slider is built following the Material Design Component's html structure and directly using their styles (IMPORTANT: This is not owned by us). The reason why the vertical option was removed from our library is that the Material Design Slider spec & implementation do not include a vertical slider.

Why not provide one anyway?

Since we are Angular Material Components, we already have incentive not to diverge from the Material Design spec. On top of this, if we were to try to implement this on our end (on top of MDC's styles) it would be a hacky workaround at best and make it more difficult to maintain the interface between our library and theirs.

Conclusion

As long as the Material Design Spec does not include a vertical slider, our library will not be implementing one.

If you'd like to advocate for a vertical slider to get added to the Material Design Spec, please feel free to visit https://m2.material.io/components/sliders. At the bottom of the page, there is a feedback link which you can use to request this feature.

If a vertical slider is ever added to the Material Design Spec, I am more than happy to reopen this issue

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/slider feature This issue represents a new feature or feature request rather than a bug or bug fix needs: discussion Further discussion with the team is needed before proceeding P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

No branches or pull requests

4 participants