bug(legacy/MDC-migration): catch-22 when trying to run the migration script

[vbraun]

Is this a regression?

• Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

TL;DR:

The legacy component migration script ng generate @angular/material:mdc-migration has a bug in v16 that was only fixed in v17. But you can't upgrade to v17 if you have legacy components. Reductio ad absurdum!

It would be great if a v16 release of the one-line fix from #28342 could be made.

Description

The current v16 release of @angular/material has a bug that does not allow the mdc migraiton script to run:

$ npx ng generate @angular/material:mdc-migration
? What components do you want to migrate? 
Schematic input does not validate against the Schema: {"directory":false,"components":[]}
Errors:

  Data path "/directory" must be string.

This was fixed in #28342 and released in 17.1.0-rc.0. The one-line fix works for me on 16.2.13.

Workaround

Manually apply 317eba0

Reproduction

N/A

Expected Behavior

ng generate @angular/material:mdc-migration should run

Actual Behavior

ng generate @angular/material:mdc-migration errors out

Environment

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 17.1.1
Node: 20.10.0
Package Manager: npm 10.2.3
OS: linux x64

Angular: 17.1.1
... animations, cli, common, compiler, compiler-cli, core
... elements, forms, language-service, localize
... platform-browser, platform-browser-dynamic, router, upgrade

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1701.1
@angular-devkit/build-angular   17.1.1
@angular-devkit/core            17.1.1
@angular-devkit/schematics      17.1.1
@angular/cdk                    16.2.13
@angular/material               16.2.13
@schematics/angular             16.2.9
ng-packagr                      17.1.2
rxjs                            7.8.1
typescript                      5.3.3
zone.js                         0.14.3

[crisbeto]

We should definitely backport the fix, but I believe that you might be able to run the script with an older version of the CLI. I think the problematic change was either in 17.1 or one of the 17.0 patch releases.

[vbraun]

I remember being able to run the migration earlier (months ago, forgot the actual version).

But at least in the 16.2.6 - 16.2.13 version range it doesn't work.

[crisbeto]

Fixed in the 16.2.14 release.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}