Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(COMPONENT): Fab buttons not using correct theming #28803

Closed
1 task done
passee opened this issue Mar 31, 2024 · 6 comments
Closed
1 task done

bug(COMPONENT): Fab buttons not using correct theming #28803

passee opened this issue Mar 31, 2024 · 6 comments
Labels
needs triage This issue needs to be triaged by the team

Comments

@passee
Copy link

passee commented Mar 31, 2024

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

16.2.14

Description

With Angular v17.3.1 and Material 3 it seems like the FAB buttons dont use the correct theming colors.
Edit: Just noticed its even more visible on mat-icon-buttons

Difference between Angular v17.3.1 and v16.2.14 (where it was correct)
v17:
image
v16:
image

Reproduction

StackBlitz links provided via angular website.

Expected Behavior

Same color theming on fab buttons like on all other buttons, like in angular v16

Actual Behavior

Primary and accent are a bit off and warn is completely off

Environment

  • Angular: v17.3.1
  • CDK/Material: 17.3.1
  • Browser: Chrome
  • Operating System: Windows 11
@passee passee added the needs triage This issue needs to be triaged by the team label Mar 31, 2024
@crisbeto
Copy link
Member

crisbeto commented Apr 1, 2024

It's showing the M3 versions of the FAB. Closing as a duplicate of #28787.

@crisbeto crisbeto closed this as completed Apr 1, 2024
@passee
Copy link
Author

passee commented Apr 1, 2024

So M3 just doesnt style fab and icon buttons in the correct color?

@crisbeto
Copy link
Member

crisbeto commented Apr 1, 2024

The color should be correct, it's just different in this version of the spec.

@crisbeto
Copy link
Member

crisbeto commented Apr 1, 2024

That being said, I just noticed that the warn color isn't showing up.

@crisbeto crisbeto reopened this Apr 1, 2024
@crisbeto
Copy link
Member

crisbeto commented Apr 2, 2024

Looks like the warn color was intentionally dropped from the FABs: https://github.com/angular/components/blob/main/src/material-experimental/theming/_color-api-back-compat.scss#L78.

@crisbeto crisbeto closed this as completed Apr 2, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs triage This issue needs to be triaged by the team
Projects
None yet
Development

No branches or pull requests

2 participants