Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Cells do not render if data is falsy #7902

Closed
andrewseguin opened this issue Oct 19, 2017 · 1 comment · Fixed by #7914
Closed

[Table] Cells do not render if data is falsy #7902

andrewseguin opened this issue Oct 19, 2017 · 1 comment · Fixed by #7914
Assignees
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects

Comments

@andrewseguin
Copy link
Contributor

If the row data evaluates to false (e.g. 0, null) then the cells will not render. This was meant to only evaluate when the data evaluates to undefined since that was the clue to the table that the row should not actually render out. However, now that a when predicate can be included in the user's row definitions, this is no longer necessary.

Plunker showing the issue: https://plnkr.co/edit/lLzdn0bSI43GjuHclJBk?p=preview

Change

const cells = rowData ? this._getCellTemplatesForRow(row) : [];

to

const cells = this._getCellTemplatesForRow(row)

@andrewseguin andrewseguin self-assigned this Oct 19, 2017
@andrewseguin andrewseguin added this to Bugs in Table Oct 19, 2017
@andrewseguin andrewseguin added the P2 The issue is important to a large percentage of users, with a workaround label Oct 19, 2017
@andrewseguin andrewseguin moved this from Bugs to Closed in Table Oct 31, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
No open projects
Table
  
Closed
Development

Successfully merging a pull request may close this issue.

1 participant