Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-infra): ensure PRs targeting a specific branch are not merged into other branches #1718

Closed
gkalpak opened this issue Oct 10, 2020 · 1 comment
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@gkalpak
Copy link
Member

gkalpak commented Oct 10, 2020

In pr/merge/defaults/labels.ts > getDefaultTargetLabelConfiguration(), there should be a check to ensure that we don't try to merge a PR to latest/rc/next branches if the PR is targeting a specific branch (for example, here).

This was originally discussed in angular/angular#38656 (comment).

@petebacondarwin petebacondarwin added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent P4 A relatively minor issue that is not relevant to core functions and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Oct 20, 2020
@josephperrott josephperrott transferred this issue from angular/angular Dec 15, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

No branches or pull requests

3 participants