Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPad Rendering Issues -- flex ordering and nested fxFlexFill #244

Closed
mmartimo opened this issue Apr 3, 2017 · 10 comments
Closed

IPad Rendering Issues -- flex ordering and nested fxFlexFill #244

mmartimo opened this issue Apr 3, 2017 · 10 comments
Labels
can be closed? P4 Low-priority issue that needs to be resolved WebKit Bug
Projects

Comments

@mmartimo
Copy link

mmartimo commented Apr 3, 2017

I have an application that is experiencing a couple issues (hopefully just user error???) as demonstrated at: https://plnkr.co/fcsPtbnXVVxTmTuVcpoa

With the desktop versions of Chrome or Edge, the application shows as:
chromefine

However on an iPad with either Safari or Chrome it shows as:
ipadfail

First issue is the ordering of the flex div... on the desktop it shows (as desired) in the order in the HTML, on the iPad the plain fxFlex (yellow) shifts to the bottom.
<div fxFlexFill fxLayout="column" fxLayoutAlign="start stretch">
<div fxFlex="100px"...>
<div fxFlex="100px"...>
<div fxFlex></div>
<div fxFlex="100px"...>
</div>

Second issue is the nesting of a fxFlexFill div... on the desktop it shows as all blue (as desired), on the iPad it sizes to the content (small blue div in large black area).
<div fxFlex style="background-color:black; color: white;">
<div fxFlexFill style="background-color:blue; ...>
</div>

@intellix
Copy link

intellix commented Apr 4, 2017

Safari doesn't support Flex :)

@mackelito
Copy link

@mackelito
Copy link

This problem will also appear on Safari on Mac.
Perhaps this will give you some idea to a solution: https://plnkr.co/edit/DT8oplpg68QCriPbgQKQ?p=preview

Happy coding! :)

@intellix
Copy link

intellix commented Apr 4, 2017

Sorry, it annoys me that caniuse claims it's supported yet height is not inherited like in eveeery other browser :D
Related: #103 #162 #201

@mmartimo
Copy link
Author

mmartimo commented Apr 7, 2017

I'm really sorry, but I'm really stuck... somehow I am missing something fundamental.

@mackelito I'm not sure what to take away from the fork to my Plunker you prepared. Beyond the "display: block;" on the body?

I get the concept that the parent needs to have height defined to calculate/display correctly in safari... I however don't observe any difference when attempting to implement others' solutions via issues 103, 162, 201. I have an updated Plunker where I've attempted each of the following with no change in display:

  1. add "display: block;" to full screen body and friends to initialize.
  2. For any naked "flex" that could be a "column", add style="flex: 1 1 100%; min-height:100vh;" to the element.
  3. Add "flex: 1 0 auto !important;" to the parent layout elements that are not correctly being filled to their children's heights.

https://plnkr.co/VxJ7CHEDRK04j65uaytn

Thanks for your patience with me... any additional guidance is very much appreciated.

@ThomasBurleson ThomasBurleson added the P4 Low-priority issue that needs to be resolved label Jun 22, 2017
@HarelM
Copy link

HarelM commented Sep 18, 2017

I had what I believe is a similar issue.
See the following issues:
IsraelHikingMap/Site#461
IsraelHikingMap/Site#458
What solved the problem for me was to remove all usages of flexLayout='column' from the html.
You can see the relevant commits related to these issues.

Any plans to fix this?
This is affecting iPhone and iPad users - which is a big portion of my mobile traffic...

@sofarojo
Copy link

Having this problem on Safari on MAC. This is not only a IPhone/Ipad issue.

Is it possible to raise the priority? Thanks :)

@ThomasBurleson ThomasBurleson added this to the Backlog milestone Nov 28, 2017
@CaerusKaru CaerusKaru added this to Pending in API Fixes via automation Jan 9, 2018
@CaerusKaru
Copy link
Member

The Plunkrs no longer work. Can anyone confirm if this is still an issue with the latest beta?

@angular angular deleted a comment from HarelM Jan 13, 2019
@CaerusKaru
Copy link
Member

I'm going to close this issue. We can reopen if someone else runs into this and can produce a new demo.

API Fixes automation moved this from Pending to Done Jan 13, 2019
@angular angular deleted a comment from HarelM Jan 13, 2019
@CaerusKaru CaerusKaru removed this from the Backlog milestone Jan 13, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
can be closed? P4 Low-priority issue that needs to be resolved WebKit Bug
Projects
API Fixes
  
Done
Development

No branches or pull requests

7 participants