fix(breakpoints): support print media #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous breakpoints defined mediaQueries like `screen and (max-width: 599px)`. This means that all responsive layouts (using .xs, .sm, etc.) will not print properly since `@media print` is excluded by the `screen and ...` breakpoint definitions. Remove all `screen and ` @media prefixes; so the layouts will appear the same on both display and print devices. Fixes #361.
ThomasBurleson
added
pr: lgtm
|
@mmalerba - this actually passed on Travis... not sure why it is show failed when it all passed. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous breakpoints defined mediaQueries like
screen and (max-width: 599px). This means thatall responsive layouts (using .xs, .sm, etc.) will not print properly since
@media printis excludedby the
screen and ...breakpoint definitions.Remove all
screen and@media prefixes; so the layouts will appear the same on both display and print devices.Fixes #361.