Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix(select): use KeyboardEvent.key instead of KeyboardEvent.keyCode for auto-completion #11313

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jun 4, 2018

Fixes #11294.

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #11294

What is the new behavior?

KeyboardEvent.key is used instead of KeyboardEvent.keyCode when getting the key pressed, for auto-completion.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 4, 2018
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added this to the 1.1.10 milestone Jun 6, 2018
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer type: bug P3: important Important issues that really should be fixed when possible. labels Jun 6, 2018
@jelbourn jelbourn merged commit daf67a8 into angular:master Jun 22, 2018
Splaktar pushed a commit that referenced this pull request Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select: doesn't autofill correctly when pressing period character
5 participants