Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

md-subheader: Broken in firefox when used with $mdDialog #1167

Closed
epelc opened this issue Jan 12, 2015 · 1 comment
Closed

md-subheader: Broken in firefox when used with $mdDialog #1167

epelc opened this issue Jan 12, 2015 · 1 comment
Assignees
Milestone

Comments

@epelc
Copy link
Contributor

epelc commented Jan 12, 2015

The header has space above it on firefox. It's been like this for the last couple of versions I just forgot to report it. It appears to be some problem with how firefox handles padding.

https://material.angularjs.org/#/demo/material.components.dialog
Click on custom dialog
dialog

If you move the header above the md-content and disable the following selector it works in firefox.

.dialogdemoBasicUsage h2.md-subheader {
    margin: -24px -24px 0px;
}

However it doesn't work very well in chrome so we need something else. Another possible problem with this fix is that it puts the header above the scroll bar instead of next to it which may or may not be good.

@epelc epelc changed the title $mdDialog: "Custom dialog" on docs header is broken $mdDialog: "Custom dialog" on docs header is broken in firefox Jan 12, 2015
@epelc epelc changed the title $mdDialog: "Custom dialog" on docs header is broken in firefox md-subheader: Broken in firefox when used with $mdDialog Jan 12, 2015
@ThomasBurleson ThomasBurleson modified the milestone: 0.7.1 Jan 15, 2015
@naomiblack naomiblack modified the milestones: 0.7.1, 0.8.0 Jan 26, 2015
@rschmukler
Copy link
Contributor

This is now fixed. The scroll bar is a different issue and one that we don't have a great solution for yet... Sadly it's not a properly styleable element in most browsers...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants