Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix(input): placeholder hidden when there is also a label on IE11 #11674

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Mar 12, 2019

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

If a md-input has both a placeholder and a label, the placeholder is invisible on IE11.

Issue Number:
Fixes #11668

What is the new behavior?

If a md-input has both a placeholder and a label, the placeholder is visible on IE11.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Verified manually in IE11 on Windows 10. No unit tests added as we don't run them against IE11.
Also verified by the reporter in #11668 (comment).

@Splaktar Splaktar added browser: IE This issue is specific to Internet Explorer severity: regression This issue is related to a regression P2: required Issues that must be fixed. labels Mar 12, 2019
@Splaktar Splaktar added this to the 1.1.14 milestone Mar 12, 2019
@Splaktar Splaktar self-assigned this Mar 12, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Mar 12, 2019
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Mar 12, 2019
@mmalerba mmalerba merged commit ddcbb2e into master Mar 13, 2019
@Splaktar Splaktar deleted the input-fixPlaceholdersIE11 branch March 13, 2019 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: IE This issue is specific to Internet Explorer cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input: placeholder with label does not display placeholder in IE11
3 participants