This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(layout): fix IE11 layout #1227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykkopycinski
changed the title
marcysutton
pushed a commit
that referenced
this pull request
Jan 19, 2015
|
Hi @marcysutton, could you explain me why you closed my PR without merge commits? And instead of this you created your own branch with the same changes and then merged your branch? |
|
There was an issue with the patch where the changes wouldn't apply, so I had to recreate them in a new branch. We have a specific merge process to keep our changelog clean. I'll try to find a way around it next time. |
marcysutton
pushed a commit
that referenced
this pull request
Jan 23, 2015
Fix in 74fe3eb was too dangerous as a global change, reverting to minimize layout issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #536