This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat(build): snapshot docs site on successful build #2852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajoslin
added
the
in progress
| git clone https://angular:$GH_TOKEN@github.com/angular/code.material.angularjs.org.git --depth=1 | ||
|
|
||
| echo "-- Remove previous snapshot..." | ||
| rm -rf code.material.angularjs.org/snapshot |
There was a problem hiding this comment.
Per discussion with @robertmesserle - we need to rename snapshot to HEAD; e.g.
code.material.angularjs.org/HEAD
HEAD == current master head commit
lastest == most recent formal release.
There was a problem hiding this comment.
I agree this makes more sense. The change has been made.
|
@robertmesserle - this lgtm |
ThomasBurleson
removed
the
in progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisite for allowing users to select a version.
In order to serve older versions, we needed to update how the site is served. We are following a similar pattern to how angularjs is being served using a seperate repo to store the snapshots and pre-built older versions (https://github.com/angular/code.material.angularjs.org).
This is only part of the larger puzzle, but I don't see any reason not to start capturing the snapshots now.
The remaining pieces include, but not limited to, taking a snapshot of a release, serving the site using the new structure and implementing version selection.