This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
update(slider): discrete sliders now support live dragging #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
force-pushed
the
wip-slider-enhance
branch
from
0ddca06
to
8848e8e
Compare
|
Ready for review and merge |
| function onInput(ev) { | ||
| if (!isSliding && ev.eventType === Hammer.INPUT_START && | ||
| !element[0].hasAttribute('disabled')) { | ||
|
|
||
| isSliding = true; | ||
| isDiscrete = angular.isDefined(attr.discrete); |
There was a problem hiding this comment.
discrete isn't going to change (it's not a bindable value; it's a one-time), so we can just move this check to line 285.
ThomasBurleson
force-pushed
the
wip-slider-enhance
branch
from
8848e8e
to
4b15c70
Compare
…ete values and snap-to animate to closest discrete value.
ThomasBurleson
force-pushed
the
wip-slider-enhance
branch
from
4b15c70
to
3d3eb71
Compare
|
This is slick! Still works great with the keyboard. 👍 |
|
😌 as I forgot about checking the keyboard support. |
ThomasBurleson
force-pushed
the
master
branch
from
56e270a
to
fd7697d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While dragging with a discrete slider, the thumb will immediately animate and slide regardless of the position in the slider bar. When released the thumb will animate and snap-to the closest discrete value.