Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Sidenav: make it display: none while hidden #345

Closed
ajoslin opened this issue Sep 30, 2014 · 3 comments
Closed

Sidenav: make it display: none while hidden #345

ajoslin opened this issue Sep 30, 2014 · 3 comments
Milestone
0.5

Comments

@ajoslin
Copy link
Contributor

ajoslin commented Sep 30, 2014

No description provided.

@ajoslin ajoslin changed the title Sidenav: fix shadows Sidenav: make it display: none while hidden Sep 30, 2014
@ajoslin ajoslin added this to the 0.5 milestone Sep 30, 2014
@marcysutton
Copy link
Contributor

Related: #330

@ajoslin ajoslin self-assigned this Oct 2, 2014
@ajoslin ajoslin closed this as completed in 8f10401 Oct 2, 2014
@marcysutton marcysutton reopened this Oct 16, 2014
@marcysutton
Copy link
Contributor

Sidenav is not really hidden when it's "closed". The links are still in the tab order. Recommending that display: none; be added after the menu is done animating.

@ajoslin
Copy link
Contributor Author

ajoslin commented Oct 17, 2014

Fixed via 105b0e0

@ajoslin ajoslin closed this as completed Oct 17, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@marcysutton @ajoslin