Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

0.11 md-chips readonly has incorrect padding #4932

Closed
osuritz opened this issue Sep 30, 2015 · 1 comment
Closed

0.11 md-chips readonly has incorrect padding #4932

osuritz opened this issue Sep 30, 2015 · 1 comment
Assignees
Milestone

Comments

@osuritz
Copy link

osuritz commented Sep 30, 2015

Setting <md-chips readonly="true"> incorrectly adds 22px padding; see Codepen Demo.

This used to work... looks like, previously, the md-readonly attribute was set on the containing <md-chips> but it is now set on each individual <md-chip>
The style has not been updated: https://github.com/angular/material/blob/master/src/components/chips/chips.scss#L62

Either that, or maybe fix the binding for md-readonly on the template: https://github.com/angular/material/blob/master/src/components/chips/js/chipsDirective.js#L93

\'md-readonly\': !$mdChipsCtrl.ngModelCtrl

to

\'md-readonly\': !$mdChipsCtrl.readonly
@topherfangio topherfangio self-assigned this Oct 1, 2015
@topherfangio topherfangio added this to the 0.12.0 milestone Oct 1, 2015
@topherfangio topherfangio modified the milestones: 0.12, 0.13 Oct 15, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc2, 1.0-rc3 Oct 30, 2015
@topherfangio
Copy link
Contributor

Fixed by #4621. Please comment if you still see issues and I will reopen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants