Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

layout: now depends on parent's display mode #4993

Closed
e-oz opened this issue Oct 3, 2015 · 7 comments
Closed

layout: now depends on parent's display mode #4993

e-oz opened this issue Oct 3, 2015 · 7 comments
Assignees
Labels
needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community P2: required Issues that must be fixed. type: docs ui: flexbox ui: layout
Milestone

Comments

@e-oz
Copy link
Contributor

e-oz commented Oct 3, 2015

Please compare this:
http://codepen.io/evgeniyoz/pen/JYWOeo?editors=100
and this:
http://codepen.io/evgeniyoz/pen/QjpOxr?editors=100

Only difference is first tag name.

@ThomasBurleson ThomasBurleson changed the title Non-reported breaking change: layout now depends on parent's display mode layout: now depends on parent's display mode Oct 3, 2015
@ThomasBurleson
Copy link
Contributor

screen shot 2015-10-03 at 7 47 20 am

@ThomasBurleson
Copy link
Contributor

It appears that the <ui-view> does not define a display or position mode.

@e-oz
Copy link
Contributor Author

e-oz commented Oct 3, 2015

Indeed. And 99% of directives with custom tag names.

@ThomasBurleson
Copy link
Contributor

I am not sure how to resolve this... as this appears to be a flexbox issue; not an issue with ngMaterial Layout which applies syntactic wrappers.

Suggestions ?

@ThomasBurleson ThomasBurleson added this to the 0.12.0 milestone Oct 3, 2015
@ThomasBurleson ThomasBurleson added the needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community label Oct 3, 2015
@e-oz
Copy link
Contributor Author

e-oz commented Oct 3, 2015

Just document it :)

@ThomasBurleson ThomasBurleson self-assigned this Oct 5, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.13, 0.12 Oct 16, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc2, 1.0-rc3 Oct 30, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc3, 1.0-rc4 Nov 7, 2015
@ThomasBurleson ThomasBurleson removed this from the 1.0-rc4 milestone Nov 16, 2015
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, 1.1.0 Jan 15, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.0, 1.3.0, Backlog, Layout Engine Apr 21, 2016
@ThomasBurleson ThomasBurleson modified the milestones: - Layout, Deprecated May 26, 2016
@ThomasBurleson
Copy link
Contributor

This issue is closed as part of our ‘Surge Focus on Material 2' efforts.
For details, see our forum posting @ http://bit.ly/1UhZyWs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community P2: required Issues that must be fixed. type: docs ui: flexbox ui: layout
Projects
None yet
Development

No branches or pull requests

2 participants