Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

font-family applied to elements without namespacing #6369

Closed
peterhodges opened this issue Dec 17, 2015 · 1 comment
Closed

font-family applied to elements without namespacing #6369

peterhodges opened this issue Dec 17, 2015 · 1 comment
Assignees
Labels
needs: team discussion This issue requires a decision from the team before moving forward. P1: urgent Urgent issues that should be addressed in the next minor or patch release.
Milestone

Comments

@peterhodges
Copy link

The material stylesheet sets the font-family on a handful of generic selectors like button, select etc.

This overwrites the font-family on these elements in the parent app.

/************
 * Defaults
 ************/

button,
select,
html,
textarea,
input {
  font-family: $font-family;
}

An app should be able to have a font-family defined on body and have this cascade down to child elements without it being overwritten by material.

Can these styles be namespaced (.md-button instead of button)?

@EladBezalel EladBezalel added the needs: team discussion This issue requires a decision from the team before moving forward. label Jan 9, 2016
@EladBezalel EladBezalel added this to the 1.1.0 milestone Jan 9, 2016
@ThomasBurleson ThomasBurleson added P1: urgent Urgent issues that should be addressed in the next minor or patch release. and removed P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Jan 15, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.0, Backlog Jan 15, 2016
@EladBezalel EladBezalel modified the milestones: 1.0.6, Backlog Feb 6, 2016
@EladBezalel
Copy link
Member

@peterhodges After discussing with the team we've come to realize that changing this implementation will be a risk for a huge breaking change that we sadly cannot take.

I'd suggest overriding this in your css,
As it's not as elegant as we wish, this is the best solution for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: team discussion This issue requires a decision from the team before moving forward. P1: urgent Urgent issues that should be addressed in the next minor or patch release.
Projects
None yet
Development

No branches or pull requests

3 participants