fix(input): match up all label transitions #6400
Conversation
Change all label `transitions` to be `0.25s` long, as the default is. Fixes angular#6328
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
@topherfangio - needs review and validation with Spec. |
Spec-wise, I think this is compliant (I can't find anything that specifies exactly what it should be). However, since we're using a special timing, I'd like to see it as a variable (perhaps |
@topherfangio good point. I'll consolidate under a variable tonight. Cheers |
@topherfangio considering that the transitions all use the $swift-ease-out-timing-function, should the timing duration ALSO be using $swift-ease-out-duration? |
Use the `$swift-ease-out-duration` in conjunction with the `$swift-ease-out-timing-function`
@tjlav5 Yes, it should use the ease-out duration. Thanks for updating! I am restarting the Travis build to ensure all the tests pass (there was an unrelated build issue which was causing the failure). |
Bumped to Topher as it seems that he's in charge here 😄 |
@tjlav5 - please Rebase with latest from |
@ThomasBurleson sorry missed the rebase request. But it looks like you handled it. |
- Thx @tjlav5 Fixes angular#6328. Closes angular#6400.
Change all label
transitions
to be0.25s
long, as the default is.Fixes #6328