Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix(input): match up all label transitions #6400

Closed
wants to merge 2 commits into from

Conversation

tjlav5
Copy link

@tjlav5 tjlav5 commented Dec 19, 2015

Change all label transitions to be 0.25s long, as the default is.

Fixes #6328

Change all label `transitions` to be `0.25s` long, as the default is.

Fixes angular#6328
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@tjlav5
Copy link
Author

tjlav5 commented Dec 19, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@ThomasBurleson ThomasBurleson added the needs: review This PR is waiting on review from the team label Dec 21, 2015
@ThomasBurleson
Copy link
Contributor

@topherfangio - needs review and validation with Spec.

@topherfangio
Copy link
Contributor

Spec-wise, I think this is compliant (I can't find anything that specifies exactly what it should be).

However, since we're using a special timing, I'd like to see it as a variable (perhaps $md-float-animation-duration or similar) so that we know that it is custom and we can easily change it in one place.

@tjlav5
Copy link
Author

tjlav5 commented Dec 28, 2015

@topherfangio good point. I'll consolidate under a variable tonight. Cheers

@tjlav5
Copy link
Author

tjlav5 commented Dec 28, 2015

@topherfangio considering that the transitions all use the $swift-ease-out-timing-function, should the timing duration ALSO be using $swift-ease-out-duration?

Use the `$swift-ease-out-duration` in conjunction with the `$swift-ease-out-timing-function`
@topherfangio
Copy link
Contributor

@tjlav5 Yes, it should use the ease-out duration. Thanks for updating!

I am restarting the Travis build to ensure all the tests pass (there was an unrelated build issue which was causing the failure).

@topherfangio topherfangio added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Jan 6, 2016
@topherfangio topherfangio added this to the 1.0.2 milestone Jan 6, 2016
@EladBezalel
Copy link
Member

Bumped to Topher as it seems that he's in charge here 😄

@ThomasBurleson ThomasBurleson modified the milestones: 1.0.2, 1.0.5 Jan 30, 2016
@ThomasBurleson
Copy link
Contributor

@tjlav5 - please Rebase with latest from master

@ThomasBurleson ThomasBurleson added needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved and removed pr: merge ready This PR is ready for a caretaker to review labels Feb 1, 2016
@tjlav5
Copy link
Author

tjlav5 commented Feb 4, 2016

@ThomasBurleson sorry missed the rebase request. But it looks like you handled it.
Cheers

ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this pull request Feb 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants