This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(datepicker): enable scrolling when scope destroyed. #7544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when we change the route, while the pane is open, the scroll mask won't be removed. That's why we should re-enable scrolling on scope destruction. In this case, we also have to check for the pane to be open, because otherwise we may accidentally remove another scroll mask. Fixes angular#7542
|
LGTM |
| this.detachCalendarPane(); | ||
| this.isCalendarOpen = false; |
There was a problem hiding this comment.
I'm not a fan of this because now the person working on this needs to know that isCalendarOpen must be set after detaching; this is a weird coupling of behaviors that makes brittle code. It would be much better to simple call enableScrolling() in the $destroy handler in addition to detachPane, which will no-op if scrolling isn't disabled.
There was a problem hiding this comment.
I can understand your thoughts. I had the behavior, you desired, before, but I thought calling enableScrolling is to generic, because detachPane will be always called after hidePane, so it made sense to me, to move the enable scroll function completely into the detachPane function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we change the route, while the pane is open, the scroll mask won't be removed.
That's why we should re-enable scrolling on scope destruction.
In this case, we also have to check for the pane to be open, because otherwise we may accidentally remove another scroll mask.
@jelbourn Can you also review please?
Fixes #7542