This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat(aria): add provider to disable console warnings. #8709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {boolean} disable Whether to show `$mdAria` console warnings. Default value is `false`. | ||
| */ | ||
| function disableWarnings(disable) { | ||
| showWarnings = !disable || false; |
There was a problem hiding this comment.
Why do we need to pass a value to a function that is only available during the config phase? Why not disableWarnings() ?
There was a problem hiding this comment.
@ThomasBurleson I actually added that to be able to reset the provider in the tests (we should not make changes for the tests to pass)
I will try to find a better solution.
devversion
force-pushed
the
feat/aria-disable-warnings
branch
from
b4b265b
to
cf4c890
Compare
ThomasBurleson
added
pr: merge ready
ThomasBurleson
pushed a commit
that referenced
this pull request
Jun 11, 2016
* Currently we're querying for buttons in the compile function, and we expecting the md-buttons to be already compiled. But that's not correct, because those will be replaced with a button, after their compile has finished. Querying for the md-button directive as well solves this. Fixes #6802. Closes #8242 Closes #8709
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3507.