This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(autocomplete): clear search text if select item cleared. #9087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently the autocomplete always updates the searchText according the changed selectedItem. * When the selectedItem was manually cleared, the searchText will be not updated. * The `searchText` should be cleared, when the `selectedItem` was cleared and the searchText still matches the selectedItem Fixes angular#8788.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searchTextshould be cleared, when theselectedItemwas cleared and the searchText still matches the selectedItem@ThomasBurleson This is the planned re-introduction, which fixes the noticed issues and also includes a test, which makes sure, that this won't happen again.
Fixes #8788.