Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

feat(themes): register theme on the fly #9475

Merged
merged 1 commit into from Oct 14, 2016
Merged

feat(themes): register theme on the fly #9475

merged 1 commit into from Oct 14, 2016

Conversation

EladBezalel
Copy link
Member

@EladBezalel EladBezalel commented Sep 1, 2016 •
edited

new pr to fix google breakage

  • Added defineTheme functionality to $mdTheming service
  • Added support for promise and a function that returns a promise on md-theme directive to support async build of themes

fixes #2965

Resubmitted this pr as #9413 was merged and reverted.

Note:
Docs will be added after #9476 will go in

@EladBezalel EladBezalel added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community needs: work labels Sep 1, 2016
@EladBezalel EladBezalel mentioned this pull request Sep 1, 2016
Merged
@ThomasBurleson ThomasBurleson added needs: presubmit and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Sep 7, 2016
@ThomasBurleson
Copy link
Contributor

Should presubmit #9484 first.

@kara
Copy link
Contributor

kara commented Sep 9, 2016

Does this PR still need work/investigation?

@ThomasBurleson ThomasBurleson removed needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community needs: work labels Sep 9, 2016
@ErinCoughlan
Copy link
Contributor

ErinCoughlan commented Sep 9, 2016 •
edited

@kara I believe still needs work. It failed the presubmit last I tired. Breaks theming in dialogs.

@EladBezalel
Copy link
Member Author

@ErinCoughlan How are we going to check it ? :\

@EladBezalel
Copy link
Member Author

As discussed with @ErinCoughlan and @ThomasBurleson this should be pre-submitted and another pr would be submitted for supporting theme inheritance for dialogs.

@EladBezalel
feat(themes): register theme on the fly
40b4de4 
- Added `defineTheme` functionality to `$mdTheming` service
- Added support for promise and a function that returns a promise on `md-theme` directive to support async build of themes

fixes #2965
EladBezalel added a commit that referenced this pull request Oct 5, 2016
@EladBezalel
feat(dialog themes): extended theme inheritance of dialogs
126a5d2 
- Dialogs now can also inherit promise/function defined themes and listen to the targetElement theme changes
- Removed wrong tests, we now assume that if an interpolation is being used in `md-theme` it was meant to be watched,
unless one-way binding (::) was applied.

Related to #9475
@EladBezalel EladBezalel mentioned this pull request Oct 5, 2016
Merged
EladBezalel added a commit that referenced this pull request Oct 5, 2016
@EladBezalel
feat(dialog themes): extended theme inheritance of dialogs
9f3b8fa 
- Dialogs now can also inherit promise/function defined themes and listen to the targetElement theme changes
- Removed wrong tests, we now assume that if an interpolation is being used in `md-theme` it was meant to be watched,
unless one-way binding (::) was applied.

Related to #9475
EladBezalel added a commit that referenced this pull request Oct 7, 2016
@EladBezalel
feat(dialog themes): extended theme inheritance of dialogs
23a08bb 
- Dialogs now can also inherit promise/function defined themes and listen to the targetElement theme changes
- Removed wrong tests, we now assume that if an interpolation is being used in `md-theme` it was meant to be watched,
unless one-way binding (::) was applied.

Related to #9475
@ThomasBurleson ThomasBurleson added the P0: critical Critical issues that must be addressed immediately. label Oct 9, 2016
@kara kara added the pr: merge ready This PR is ready for a caretaker to review label Oct 14, 2016
@kara kara merged commit 7090a1f into master Oct 14, 2016
@ThomasBurleson
Copy link
Contributor

Thx @kara

@EladBezalel EladBezalel deleted the feat/themes-on-the-fly branch October 17, 2016 17:05
EladBezalel added a commit that referenced this pull request Oct 17, 2016
@EladBezalel
feat(dialog themes): extended theme inheritance of dialogs
fd25c3c 
- Dialogs now can also inherit promise/function defined themes and listen to the targetElement theme changes
- Removed wrong tests, we now assume that if an interpolation is being used in `md-theme` it was meant to be watched,
unless one-way binding (::) was applied.

Related to #9475
EladBezalel added a commit that referenced this pull request Oct 25, 2016
@EladBezalel
feat(dialog themes): extended theme inheritance of dialogs
a65e080 
- Dialogs now can also inherit promise/function defined themes and listen to the targetElement theme changes
- Removed wrong tests, we now assume that if an interpolation is being used in `md-theme` it was meant to be watched,
unless one-way binding (::) was applied.

Related to #9475
jelbourn pushed a commit that referenced this pull request Oct 27, 2016
@EladBezalel @jelbourn
feat(dialog themes): extended theme inheritance of dialogs (#9762)
b7ae33e 
- Dialogs now can also inherit promise/function defined themes and listen to the targetElement theme changes
- Removed wrong tests, we now assume that if an interpolation is being used in `md-theme` it was meant to be watched,
unless one-way binding (::) was applied.

Related to #9475
@EladBezalel EladBezalel mentioned this pull request Mar 5, 2017
Closed
@Splaktar Splaktar added this to the 1.1.2 milestone Apr 5, 2018
Splaktar added a commit that referenced this pull request Apr 5, 2018
@Splaktar
docs(mdThemingProvider): add missing documentation
521b536 
the APIs were covered some in the guide, but not in the service docs
update existing docs for consistency

Relates to #2965. Relates to #9475. Relates to #9476.
Relates to #10458. Relates to #10458.
@Splaktar Splaktar mentioned this pull request Apr 5, 2018
Merged
3 tasks
jelbourn pushed a commit that referenced this pull request Apr 6, 2018
@Splaktar @jelbourn
docs(mdThemingProvider): add missing documentation (#11209)
40e1f2d 
the APIs were covered some in the guide, but not in the service docs
update existing docs for consistency

Relates to #2965. Relates to #9475. Relates to #9476.
Relates to #10458. Relates to #10458.
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Apr 6, 2018
Merged
3 tasks
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
@Splaktar @chmelevskij
docs(mdThemingProvider): add missing documentation (angular#11209)
1747f01 
the APIs were covered some in the guide, but not in the service docs
update existing docs for consistency

Relates to angular#2965. Relates to angular#9475. Relates to angular#9476.
Relates to angular#10458. Relates to angular#10458.
Splaktar added a commit that referenced this pull request Jul 31, 2018
@Splaktar
docs(mdThemingProvider): add missing documentation (#11209)
649d6aa 
the APIs were covered some in the guide, but not in the service docs
update existing docs for consistency

Relates to #2965. Relates to #9475. Relates to #9476.
Relates to #10458. Relates to #10458.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ErinCoughlan ErinCoughlan

@EladBezalel EladBezalel

Labels
P0: critical Critical issues that must be addressed immediately. pr: merge ready This PR is ready for a caretaker to review
Projects
No open projects
Theme Explorer
Blocking
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

$mdThemingProvider - registering a theme on the fly
5 participants
@EladBezalel @ThomasBurleson @kara @ErinCoughlan @Splaktar