This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(constant): remove dependency on $sniffer #9875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var vendorPrefix = $sniffer.vendorPrefix; | ||
| var prefixTestEl = document.createElement('div'); | ||
| var vendorPrefix = getVendorPrefix(); |
There was a problem hiding this comment.
Plz use getVendorPrefix( prefixTestEl );
There was a problem hiding this comment.
Done. Also added it to hasStyleProperty.
The `$mdConstant` service uses Angular's `$sniffer` service to determine the browser's prefix via the `vendorPrefix`. `vendorPrefix` was removed with angular/angular.js@35482ba. These changes provide the same functionality, without depending on `$sniffer`. They also fix the current CI failures.
crisbeto
force-pushed
the
sniffer-errors
branch
from
81ac844
to
84758ca
Compare
ThomasBurleson
approved these changes
Oct 20, 2016
| return match[0]; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
what is returned if not a match? "" ?
There was a problem hiding this comment.
It's undefined. That's what got returned before as well.
ThomasBurleson
added
needs: presubmit
and removed
needs: review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$mdConstantservice uses Angular's$snifferservice to determine the browser's prefix via thevendorPrefix.vendorPrefixwas removed with angular/angular.js@35482ba.These changes provide the same functionality, without depending on
$sniffer. They also fix the current CI failures.