feat(overlay): expose flexible overlay features through CdkConnectedOverlay #11069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Apr 30, 2018
| set growAfterOpen(value: any) { this._growAfterOpen = coerceBooleanProperty(value); } | ||
|
|
||
| /** Whether the overlay can be pushed on-screen if none of the provided positions fit. */ | ||
| @Input('cdkConnectedOverlayGrowAfterOpen') |
There was a problem hiding this comment.
Add a unit test that adds these just to ensure they don't break if e.g. someone accidentally renames a input or something minor like that?
…verlay Exposes all of the new flexible positioning features through the `CdkConnectedOverlay` directive. They're still all set to be opt-in for now, in order to avoid breaking changes.
crisbeto
force-pushed
the
overlay-directive-flexible-features
branch
from
c336c2b
to
8ccb1a9
Compare
|
Sorry for the delay @jelbourn, it looks like I missed the notification for this one. I've addressed the feedback now. |
jelbourn
approved these changes
May 3, 2018
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes all of the new flexible positioning features through the
CdkConnectedOverlaydirective. They're still all set to be opt-in for now, in order to avoid breaking changes.