fix(overlay): global overlay incorrectly handling left/right position when RTL is set on body #11412
Conversation
crisbeto
added
the
blocked
googlebot
added
the
cla: yes
crisbeto
removed
the
blocked
|
@jelbourn this one is unblocked now. |
crisbeto
force-pushed
the
global-overlay-rtl
branch
from
1134324
to
9df00ca
Compare
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
If you can, could you push some new hash so that CircleCI tries to re-run? Would like it to be green before we merge |
… when RTL is set on body We use `justify-content` to position global overlay to the left or right, however `justify-content` gets inverted when the element is in RTL. Since our methods are called explicitly `left` and `right`, the expectation is that the element would stay to the left or right, no matter what the direction is. This is an issue if the `dir` is set on the `body` or `html` tags, because it'll end up propagating down to the overlay wrapper, causing its directions to be inverted. These changes invert `justify-content` in RTL, in order to ensure that the overlay behaves as expected. Relates to angular#11393.
crisbeto
force-pushed
the
global-overlay-rtl
branch
from
9df00ca
to
d3a3136
Compare
|
Done @andrewseguin. |
… when RTL is set on body (#11412) We use `justify-content` to position global overlay to the left or right, however `justify-content` gets inverted when the element is in RTL. Since our methods are called explicitly `left` and `right`, the expectation is that the element would stay to the left or right, no matter what the direction is. This is an issue if the `dir` is set on the `body` or `html` tags, because it'll end up propagating down to the overlay wrapper, causing its directions to be inverted. These changes invert `justify-content` in RTL, in order to ensure that the overlay behaves as expected. Relates to #11393.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
We use
justify-contentto position global overlay to the left or right, howeverjustify-contentgets inverted when the element is in RTL. Since our methods are called explicitlyleftandright, the expectation is that the element would stay to the left or right, no matter what the direction is. This is an issue if thediris set on thebodyorhtmltags, because it'll end up propagating down to the overlay wrapper, causing its directions to be inverted. These changes invertjustify-contentin RTL, in order to ensure that the overlay behaves as expected.Relates to #11393.