Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): panel positions not changing if position is updated after first open #11707

Merged
merged 1 commit into from Jun 20, 2018
Merged

fix(menu): panel positions not changing if position is updated after first open #11707

merged 1 commit into from Jun 20, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 7, 2018

Fixes the menu's panel position not being accurate if it's xPosition or yPosition is updated after it has been opened for the first time.

Fixes #11668.

@crisbeto
fix(menu): panel positions not changing if position is updated after …
f68350d 
…first open

Fixes the menu's panel position not being accurate if it's `xPosition` or `yPosition` is updated after it has been opened for the first time.

Fixes angular#11668.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 7, 2018
jelbourn
jelbourn approved these changes Jun 7, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 7, 2018
@tinayuangao tinayuangao merged commit 50ea837 into angular:master Jun 20, 2018
tinayuangao pushed a commit that referenced this pull request Jun 20, 2018
@crisbeto @tinayuangao
fix(menu): panel positions not changing if position is updated after …
671ad82 
…first open (#11707)

Fixes the menu's panel position not being accurate if it's `xPosition` or `yPosition` is updated after it has been opened for the first time.

Fixes #11668.
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@crisbeto @victoriaaa234
fix(menu): panel positions not changing if position is updated after …
6016f2b 
…first open (#11707)

Fixes the menu's panel position not being accurate if it's `xPosition` or `yPosition` is updated after it has been opened for the first time.

Fixes #11668.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-menu: xPosition and yPosition binding not working
4 participants
@crisbeto @jelbourn @googlebot @tinayuangao