Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): error when typing in input with disabled autocomplete and no panel #11881

Merged
merged 1 commit into from Jul 10, 2018
Merged

fix(autocomplete): error when typing in input with disabled autocomplete and no panel #11881

merged 1 commit into from Jul 10, 2018

Conversation

crisbeto
Copy link
Member

Fixes an edge case where the input will throw an error if it has a disabled autocomplete and no autocomplete panel.

Fixes #11876.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 21, 2018
jelbourn
jelbourn approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 21, 2018
@josephperrott josephperrott added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Jun 29, 2018
@ngbot
Copy link

ngbot bot commented Jun 29, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto
fix(autocomplete): error when typing in input with disabled autocompl…
7879ab3 
…ete and no panel

Fixes an edge case where the input will throw an error if it has a disabled autocomplete and no autocomplete panel.

Fixes angular#11876.
@crisbeto crisbeto force-pushed the 11876/disabled-autocomplete-error branch from 6b80423 to 7879ab3 Compare June 30, 2018 07:56
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Jun 30, 2018
@jelbourn jelbourn merged commit 6b1a672 into angular:master Jul 10, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@crisbeto @victoriaaa234
fix(autocomplete): error when typing in input with disabled autocompl…
726533b 
…ete and no panel (#11881)

Fixes an edge case where the input will throw an error if it has a disabled autocomplete and no autocomplete panel.

Fixes #11876.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
4 participants
@crisbeto @jelbourn @googlebot @josephperrott