fix(select): don't prevent enter and space keys if a modifier is pressed #14090
+88
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
* Only handles the space and enter keys, and prevents their default actions, if none of the modifier keys are pressed. * Moves some tests that were testing `mat-option` logic into the `mat-option` specs.
crisbeto
force-pushed
the
select-selection-key-modifiers
branch
from
436ef60
to
88db484
Compare
jelbourn
added
pr: lgtm
action: merge
IlCallo
pushed a commit
to IlCallo/material2
that referenced
this pull request
Nov 15, 2018
…sed (angular#14090) * Only handles the space and enter keys, and prevents their default actions, if none of the modifier keys are pressed. * Moves some tests that were testing `mat-option` logic into the `mat-option` specs.
josephperrott
pushed a commit
that referenced
this pull request
Nov 19, 2018
…sed (#14090) * Only handles the space and enter keys, and prevents their default actions, if none of the modifier keys are pressed. * Moves some tests that were testing `mat-option` logic into the `mat-option` specs.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mat-optionlogic into themat-optionspecs.Note: targeting
minorsince the modifier key API were introduced in minor.