Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run v8 migration schematics for v8 beta and rc releases #15753

Merged
merged 1 commit into from Apr 8, 2019

Conversation

devversion
Copy link
Member

Currently the V8 schematic migrations only run for 8.0.0 which does not
include any betas or release candidates. We want to run the schematic in
the beta's and RC in order to get early feedback about the schematics. Enabling
it promptly with V8 stable release can result in accidental breakages that we would
like to fix/identify before.

Currently the V8 schematic migrations only run for `8.0.0` which does not
include any betas or release candidates. We want to run the schematic in
the beta's and RC in order to get early feedback about the schematics. Enabling
it promptly with V8 stable release can result in accidental breakages that we would
like to fix/identify before.
@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Apr 8, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 8, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Apr 8, 2019
@mmalerba mmalerba merged commit bb5d544 into angular:master Apr 8, 2019
@devversion devversion deleted the feat/v8-migrations-for-beta-rc branch April 8, 2019 18:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants