fix(slide-toggle): input not updated after drag #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MdSlideToggle` uses the OnPush ChangeDetection strategy for the component. **Problem Explanation** When the thumb is being dragged and the value changes, the new value is currently applied after a timeout. This timeout does not trigger any change detection, and the new value won't be applied to the underlying input. **Solution** With this change, the new value is applied immediately in the `dragend` event (because events trigger a change detection) and just the `dragging` state will be updated in the next tick. The timeout is required to ensure that there will be no `click` event after the `dragend` event.
googlebot
added
the
cla: yes
kara
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MdSlideToggleuses the OnPush ChangeDetection strategy for the component.Problem Explanation
When the thumb is being dragged and the value changes, the new value is currently applied after a timeout.
This timeout does not trigger any change detection, and the new value won't be applied to the underlying input.
Solution
With this change, the new value is applied immediately in the
dragendevent (because events trigger a change detection) and just thedraggingstate will be updated in the next tick.The timeout is required to ensure that there will be no
clickevent after thedragendevent.