fix(tabs): server-side rendering error when aligning ink bar #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a server-side rendering error in the ink bar due to a lack of `requestAnimationFrame`. The error is being logged, but it didn't fail the build, because it happens in a lifecycle hook. * Enables the checkbox and button toggle cases in the kitchen sink since it looks like they're not failing anymore.
googlebot
added
the
cla: yes
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 1, 2017
* Currently the build won't fail if an error is thrown inside a lifecycle hook, because `platform-server` writes it to STDERR, but still exits with a 0 code. These changes set up the Universal testing task to fail for these cases as well. This should prevent issues like angular#5455 in the future. * Stops logging the entire rendered document after the prerender task is done. This makes the log a bit easier to look through.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 1, 2017
* Currently the build won't fail if an error is thrown inside a lifecycle hook, because `platform-server` writes it to STDERR, but still exits with a 0 code. These changes set up the Universal testing task to fail for these cases as well. This should prevent issues like angular#5455 in the future. * Stops logging the entire rendered document after the prerender task is done. This makes the log a bit easier to look through.
mmalerba
pushed a commit
that referenced
this pull request
Jul 5, 2017
* Currently the build won't fail if an error is thrown inside a lifecycle hook, because `platform-server` writes it to STDERR, but still exits with a 0 code. These changes set up the Universal testing task to fail for these cases as well. This should prevent issues like #5455 in the future. * Stops logging the entire rendered document after the prerender task is done. This makes the log a bit easier to look through.
jelbourn
added
pr: lgtm
action: merge
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
* Currently the build won't fail if an error is thrown inside a lifecycle hook, because `platform-server` writes it to STDERR, but still exits with a 0 code. These changes set up the Universal testing task to fail for these cases as well. This should prevent issues like angular#5455 in the future. * Stops logging the entire rendered document after the prerender task is done. This makes the log a bit easier to look through.
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
…#5455) * Fixes a server-side rendering error in the ink bar due to a lack of `requestAnimationFrame`. The error is being logged, but it didn't fail the build, because it happens in a lifecycle hook. * Enables the checkbox and button toggle cases in the kitchen sink since it looks like they're not failing anymore.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestAnimationFrame. The error is being logged, but it didn't fail the build, because it happens in a lifecycle hook.