feat(menu): add injection token for overriding the default options #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
approved these changes
Jul 24, 2017
src/lib/menu/menu-directive.ts
Outdated
| @@ -29,6 +31,16 @@ import {Subscription} from 'rxjs/Subscription'; | |||
| import {transformMenu, fadeInItems} from './menu-animations'; | |||
| import {ESCAPE} from '../core/keyboard/keycodes'; | |||
|
|
|||
| /** Default `md-menu` options that can be overriden. */ | |||
There was a problem hiding this comment.
Typo: overriden -> overridden
src/lib/menu/menu.spec.ts
Outdated
| }).compileComponents(); | ||
| })); | ||
|
|
||
| it('should allow for the default menu options to be overriden', () => { |
There was a problem hiding this comment.
Typo: overriden -> overridden
kara
added
pr: lgtm
action: merge
Adds a new injection token that allows the consumer to override the default values for the `xPosition`, `yPosition` and `overlapTrigger` options. Fixes angular#5479.
crisbeto
force-pushed
the
5479/md-menu-defaults
branch
from
7e8d4b8
to
b15c577
Compare
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new injection token that allows the consumer to override the default values for the
xPosition,yPositionandoverlapTriggeroptions.Fixes #5479.