fix(table): empty string should be sorted right

[andrewseguin]

Previously, an empty string gets converted to 0 and comes after other values. E.g. ' ' would come after 'x'.

Fixes #7460

[jelbourn]

LGTM, add merge-ready when ready

[jelbourn]

This conditional is a bit long to be single-lined

[Bsujeet]

i just wanted to ask if the table should sort the column where the is same i.e all the rows of that column contain same data.

this is my table before sort.

this is my table after sort on DiskType column..

do i need to change anything in my sort function...

Thanks

[andrewseguin]

@Bsujeet What you are looking for is a stable sort, but the ES7 spec does not specify that native sorting must be stable. Each browser has its own way of sorting when array.sort is called and there's no consistency.

For a stable sort, you'll want to adjust your comparator to account for the object's index if the comparison is equal. For some discussion on how to do this, try starting with this StackOverflow question.

[Bsujeet]

Thanks it was helpfull

[prabhat112]

I have 5.0.0 and I still have this issue. In which release has this been released ?

[andrewseguin]

Should be out already - feel free to open an issue with reproduction steps so we can investigate if the issue persists

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}