Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mat-option: Unable to Set Height #8054

Closed
mikeomeara1 opened this issue Oct 26, 2017 · 5 comments
Closed

mat-option: Unable to Set Height #8054

mikeomeara1 opened this issue Oct 26, 2017 · 5 comments

Comments

@mikeomeara1
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Changing the height of a mat-option element shouldn't impact where the selected item appears inside
mat-select-content

What is the current behavior?

Pre Beta.12 setting an explicit height for mat-option worked as excepted. Post Beta.12 modifying the option height makes the selected option appear outside the visible mat-select-content area.

What are the steps to reproduce?

https://plnkr.co/edit/CULSXZovARH9HdKFm3d4?p=preview

This is a standard mat-select with an explicit height set on mat-option (35px).

  1. Open select
  2. Selected item is not visible

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular: 4.4.3
Material: 2.0.0-beta.12
OS: Windows 10
Typescript: 2.2.2
Browser: Chrome Version 61.0.3163.100 (Official Build) (64-bit)

Many apologies guys if this one is already logged too. I am searching around before logging but sometimes it's hard to find open/related issues.

Thanks so much!

@crisbeto
Copy link
Member

Closing as a duplicate of #3419. Also FWIW, setting the option height has never been supported.

@mikeomeara1
Copy link
Author

mikeomeara1 commented Oct 26, 2017

@crisbeto Fair enough on the dupe I suppose but I can confirm to you that explicit height on mat-option (md-option) did in fact work in Beta.10 and stopped working sometime between Beta.11-Beta.12.

https://plnkr.co/edit/RkT5Y7JPq5mmqrp9A1QY?p=preview

Although I understand the difference between "working" and "supported"...however just to point that out.

@crisbeto
Copy link
Member

Yep it may have worked, but all our calculations are based around a certain height for the options.

@mikeomeara1
Copy link
Author

Bummer. OK thanks for clearing that up.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants