Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spinner): set initial value for spinner to 0 #8139

Merged
merged 1 commit into from Nov 2, 2017
Merged

fix(spinner): set initial value for spinner to 0 #8139

merged 1 commit into from Nov 2, 2017

Conversation

josephperrott
Copy link
Member

Fixes #8126

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2017
jelbourn
jelbourn approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will wait for @crisbeto to chime in since there may be an implication here I'm not thinking of

src/lib/progress-spinner/progress-spinner.spec.ts Outdated
@@ -4,7 +4,7 @@ import {By} from '@angular/platform-browser';
import {MatProgressSpinnerModule} from './index';


describe('MatProgressSpinner', () => {
fdescribe('MatProgressSpinner', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fdescribe

crisbeto
crisbeto approved these changes Oct 31, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 31, 2017
@andrewseguin andrewseguin merged commit 9e4c636 into angular:master Nov 2, 2017
@josephperrott josephperrott deleted the spinner branch November 10, 2017 19:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress Spinner initialization bug
5 participants
@josephperrott @jelbourn @crisbeto @googlebot @andrewseguin