fix(icon): handle values with unnecessary spaces being passed into fontIcon and fontSet #9056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntIcon and fontSet Handles values with trailing/leading spaces, as well as space-separated values being passed into the `fontIcon` and `fontSet` properties, rather than letting the browser throw a DOM exception. Fixes angular#9054.
googlebot
added
the
cla: yes
jelbourn
reviewed
Dec 19, 2017
| * have to trim the value and omit space-separated values. | ||
| */ | ||
| private _cleanupFontValue(value: string) { | ||
| return typeof value === 'string' ? value.trim().split(' ')[0] : value; |
There was a problem hiding this comment.
Looks like ligatures can include whitespace:
https://twitter.com/larrythefox/status/422813021807714304
There was a problem hiding this comment.
Our current logic still doesn't hold up though. We used to take the value verbatim and set it as a class which is invalid. I switched it up to only take it up to the first space.
There was a problem hiding this comment.
Oh, right. I mixed up class and ligature
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
…ntIcon and fontSet (angular#9056) Handles values with trailing/leading spaces, as well as space-separated values being passed into the `fontIcon` and `fontSet` properties, rather than letting the browser throw a DOM exception. Fixes angular#9054.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
…ntIcon and fontSet (angular#9056) Handles values with trailing/leading spaces, as well as space-separated values being passed into the `fontIcon` and `fontSet` properties, rather than letting the browser throw a DOM exception. Fixes angular#9054.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles values with trailing/leading spaces, as well as space-separated values being passed into the
fontIconandfontSetproperties, rather than letting the browser throw a DOM exception.Fixes #9054.