Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layout): add window breakpoints from spec #9318

Merged
merged 2 commits into from Jan 26, 2018
Merged

feat(layout): add window breakpoints from spec #9318

merged 2 commits into from Jan 26, 2018

Conversation

CDDelta
Copy link

@CDDelta CDDelta commented Jan 10, 2018

Fixes #9212

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 10, 2018
WindowSmall: '(min-width: 600px) and (max-width: 959px)',
WindowMedium: '(min-width: 960px) and (max-width: 1279px)',
WindowLarge: '(min-width: 1280px) and (max-width: 1919px)',
WindowXLarge: '(min-width: 1920px)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephperrott I looked at the spec and it's not clear to me what "Window" even means in that table. Is it supposed be be a "desktop browser window"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so. That mostly is coming from listing breakpoints "across desktop, mobile and tablet". And mobile (written elsewhere as handset) and tablet are referenced so the others must be desktop?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to make these DesktopSmall, DesktopMedium, etc.?

It would also be nice to confirm with the Material Design team.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion, @jelbourn and I determined that we think the best option would be to drop the prefix of the sizes entirely.

XSmall: '(max-width: 599px)',
Small: '(min-width: 600px) and (max-width: 959px)',
Medium: '(min-width: 960px) and (max-width: 1279px)',
Large: '(min-width: 1280px) and (max-width: 1919px)',
XLarge: '(min-width: 1920px)',

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jan 26, 2018
@jelbourn jelbourn merged commit 1038950 into angular:master Jan 26, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement window breakpoints from Material guidelines
4 participants