Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk-input): move input autofill and autosize utils into cdk #9831

Merged
merged 6 commits into from Mar 13, 2018

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Feb 8, 2018

Since the autofill isn't slated for release until major its fine to just move it. For autosize I left a mat- alias for now.

Also fixes a bug I noticed where autosize doesn't work on a plain textarea with no other angular fanciness

@mmalerba mmalerba added pr: needs review target: major This PR is targeted for the next major release labels Feb 8, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 8, 2018
@jelbourn
Copy link
Member

jelbourn commented Feb 9, 2018

There's a failure in the bazel build

@mmalerba
Copy link
Contributor Author

mmalerba commented Feb 9, 2018

@jelbourn fixed

@jelbourn
Copy link
Member

jelbourn commented Feb 9, 2018

Different error now:

src/lib/input/autosize.ts(9,35): error TS2307: Cannot find module '@angular/cdk/input'.
src/lib/input/autosize.ts(31,50): error TS2339: Property 'minRows' does not exist on type 'MatTextareaAutosize'.
src/lib/input/autosize.ts(32,48): error TS2339: Property 'minRows' does not exist on type 'MatTextareaAutosize'.
src/lib/input/autosize.ts(35,50): error TS2339: Property 'maxRows' does not exist on type 'MatTextareaAutosize'.
src/lib/input/autosize.ts(36,48): error TS2339: Property 'maxRows' does not exist on type 'MatTextareaAutosize'.
src/lib/input/input.ts(27,31): error TS2307: Cannot find module '@angular/cdk/input'.
src/lib/input/input-module.ts(9,27): error TS2307: Cannot find module '@angular/cdk/input'.

@@ -61,6 +61,7 @@
/src/cdk/bidi/** @jelbourn
/src/cdk/coercion/** @jelbourn
/src/cdk/collections/** @jelbourn @crisbeto @andrewseguin
/src/cdk/input/** @mmalerba
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't want to call this "input". It's overloaded with @Input and applies to more than just the <input> element (textarea).

Something like cdk/text-fieldor cdk/text-entry would be more explicit.

@StephenFluin do you have any input on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either is just fine. I prefer cdk/text-field (entry is a brand new term which probably has its own meaning and connotations, but we already use field).

@mmalerba mmalerba force-pushed the cdk-input branch 2 times, most recently from 046fdf5 to 4f42901 Compare February 21, 2018 00:27
@mmalerba
Copy link
Contributor Author

@jelbourn renamed input to text-field

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It would be good to add docs in a follow-up PR

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed pr: needs review labels Feb 22, 2018
@jelbourn
Copy link
Member

Caretaker note: will need build rule update

@mmalerba mmalerba force-pushed the cdk-input branch 2 times, most recently from 21c7b3a to 8cda50f Compare March 6, 2018 16:43
@jelbourn
Copy link
Member

jelbourn commented Mar 9, 2018

@mmalerba needs rebase

@mmalerba
Copy link
Contributor Author

mmalerba commented Mar 9, 2018

@jelbourn done

@mmalerba mmalerba merged commit ced9c90 into angular:master Mar 13, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants