New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk-input): move input autofill and autosize utils into cdk #9831
Conversation
There's a failure in the bazel build |
@jelbourn fixed |
Different error now:
|
71e51ec
to
2e37ded
Compare
.github/CODEOWNERS
Outdated
@@ -61,6 +61,7 @@ | |||
/src/cdk/bidi/** @jelbourn | |||
/src/cdk/coercion/** @jelbourn | |||
/src/cdk/collections/** @jelbourn @crisbeto @andrewseguin | |||
/src/cdk/input/** @mmalerba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't want to call this "input". It's overloaded with @Input
and applies to more than just the <input>
element (textarea
).
Something like cdk/text-field
or cdk/text-entry
would be more explicit.
@StephenFluin do you have any input on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either is just fine. I prefer cdk/text-field (entry is a brand new term which probably has its own meaning and connotations, but we already use field).
046fdf5
to
4f42901
Compare
@jelbourn renamed input to text-field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It would be good to add docs in a follow-up PR
Caretaker note: will need build rule update |
21c7b3a
to
8cda50f
Compare
@mmalerba needs rebase |
@jelbourn done |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Since the autofill isn't slated for release until major its fine to just move it. For autosize I left a mat- alias for now.
Also fixes a bug I noticed where autosize doesn't work on a plain textarea with no other angular fanciness