fix(schematics): make v6 migration work #10853
Conversation
jelbourn
requested review from
crisbeto,
josephperrott,
mmalerba and
tinayuangao
googlebot
added
the
cla: yes
| @@ -32,7 +32,7 @@ const allScssGlob = join(buildConfig.packagesDir, '**/*.scss'); | |||
| const schematicsGlobs = [ | |||
| // File templates and schemas are copied as-is from source. | |||
| join(schematicsDir, '**/+(data|files)/**/*'), | |||
| join(schematicsDir, '**/+(schema|collection).json'), | |||
| join(schematicsDir, '**/+(schema|collection|migration).json'), | |||
There was a problem hiding this comment.
does this need to be updated as well? https://github.com/angular/material2/blob/master/src/lib/schematics/BUILD.bazel#L19
There was a problem hiding this comment.
Yep, good catch. Done.
mmalerba
added
pr: lgtm
action: merge
| @@ -20,7 +20,7 @@ | |||
| "docs": "gulp docs", | |||
| "api": "gulp api-docs" | |||
| }, | |||
| "version": "6.0.0-rc.5", | |||
| "version": "6.0.0-rc.11", | |||
There was a problem hiding this comment.
Why is it going from rc.5 to rc.11?
There was a problem hiding this comment.
My guess is because this was published to NPM as rc.11 already, and this is an after-the-fact update
There was a problem hiding this comment.
Yep; it's not yet possible to test ng update without publishing to npm
This includes: * Adding missing schema json to package * Add missing packageGroup entries to material, cdk, and moment-adapter * Move schematics for migration to the migrate-specific schema * Bump version to 6.0.0-rc.11
jelbourn
force-pushed
the
ng-update-actually-work
branch
from
de2c754
to
39abfcc
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This includes: