Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date range #13203

Merged
merged 17 commits into from Oct 30, 2018
Merged

Date range #13203

merged 17 commits into from Oct 30, 2018

Conversation

roboshoes
Copy link
Contributor

@roboshoes roboshoes commented Sep 19, 2018 •
edited

Every MatCalendarCell now also carries a generic date object. That allows the cell to determine if the respective day is in the current selection.

the MatDateSelection has been extended to a contains method. This allows a selection to determine if a date is included.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Sep 19, 2018
@ngbot
Copy link

ngbot bot commented Sep 19, 2018

Hi @MathiasPaumgarten! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Sep 19, 2018
roboshoes
roboshoes commented Sep 19, 2018
View reviewed changes
src/lib/core/datetime/date-selection.ts Outdated Show resolved Hide resolved
src/lib/datepicker/calendar-body.html Outdated Show resolved Hide resolved
@josephperrott josephperrott removed their request for review October 1, 2018 13:36
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Oct 16, 2018
@mmalerba mmalerba force-pushed the date-range branch 2 times, most recently from f62af05 to 87bd93d Compare October 23, 2018 20:35
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 24, 2018
roboshoes
roboshoes commented Oct 24, 2018
View reviewed changes
src/lib/datepicker/calendar-body.ts Show resolved Hide resolved
src/lib/datepicker/calendar.ts Outdated Show resolved Hide resolved
src/lib/datepicker/calendar.ts Outdated Show resolved Hide resolved
src/lib/datepicker/month-view.ts Outdated Show resolved Hide resolved
src/lib/datepicker/month-view.ts Show resolved Hide resolved
mmalerba
mmalerba reviewed Oct 24, 2018
View reviewed changes
src/lib/core/datetime/date-selection.ts Outdated Show resolved Hide resolved
src/lib/datepicker/calendar-body.ts Outdated Show resolved Hide resolved
src/lib/core/datetime/date-selection.ts Outdated Show resolved Hide resolved
src/lib/datepicker/calendar-body.ts Show resolved Hide resolved
src/lib/datepicker/calendar.ts Outdated Show resolved Hide resolved
src/lib/datepicker/datepicker.ts Outdated Show resolved Hide resolved
src/lib/datepicker/datepicker.ts Outdated Show resolved Hide resolved
src/lib/datepicker/datepicker.ts Outdated Show resolved Hide resolved
src/lib/datepicker/month-view.ts Outdated Show resolved Hide resolved
src/lib/datepicker/month-view.ts Outdated Show resolved Hide resolved
mmalerba
mmalerba reviewed Oct 26, 2018
View reviewed changes
src/lib/datepicker/datepicker-input.ts Outdated Show resolved Hide resolved
src/lib/datepicker/datepicker.ts Outdated Show resolved Hide resolved
src/lib/datepicker/datepicker.ts Outdated Show resolved Hide resolved
src/lib/datepicker/datepicker.ts Outdated Show resolved Hide resolved
src/lib/datepicker/datepicker.ts Outdated Show resolved Hide resolved
src/lib/datepicker/multi-year-view.ts Outdated Show resolved Hide resolved
src/lib/datepicker/year-view.ts Outdated Show resolved Hide resolved
@mmalerba mmalerba merged commit 2d59b5c into angular:date-range Oct 30, 2018
mmalerba pushed a commit that referenced this pull request Oct 30, 2018
@roboshoes @mmalerba
Date range (#13203)
2ae4065 
Every MatCalendarCell now also carries a generic date object. That allows the cell to determine if the respective day is in the current selection.

the MatDateSelection has been extended to a `contains` method. This allows a selection to determine if a date is included.
mmalerba pushed a commit that referenced this pull request Oct 31, 2018
@roboshoes @mmalerba
Date range (#13203)
b444647 
Every MatCalendarCell now also carries a generic date object. That allows the cell to determine if the respective day is in the current selection.

the MatDateSelection has been extended to a `contains` method. This allows a selection to determine if a date is included.
mmalerba pushed a commit that referenced this pull request Dec 14, 2018
@roboshoes @mmalerba
Date range (#13203)
325f6a5 
Every MatCalendarCell now also carries a generic date object. That allows the cell to determine if the respective day is in the current selection.

the MatDateSelection has been extended to a `contains` method. This allows a selection to determine if a date is included.
@mmalerba mmalerba added this to In progress in Date range picker via automation Jan 14, 2019
@mmalerba mmalerba moved this from In progress to Done in Date range picker Jan 14, 2019
mmalerba pushed a commit that referenced this pull request Jan 15, 2019
@roboshoes @mmalerba
Date range (#13203)
8043fdf 
Every MatCalendarCell now also carries a generic date object. That allows the cell to determine if the respective day is in the current selection.

the MatDateSelection has been extended to a `contains` method. This allows a selection to determine if a date is included.
mmalerba pushed a commit to mmalerba/components that referenced this pull request Jan 27, 2019
@roboshoes @mmalerba
Date range (angular#13203)
26e67c4 
Every MatCalendarCell now also carries a generic date object. That allows the cell to determine if the respective day is in the current selection.

the MatDateSelection has been extended to a `contains` method. This allows a selection to determine if a date is included.
mmalerba pushed a commit that referenced this pull request Apr 15, 2019
@roboshoes @mmalerba
Date range (#13203)
4f3bd49 
Every MatCalendarCell now also carries a generic date object. That allows the cell to determine if the respective day is in the current selection.

the MatDateSelection has been extended to a `contains` method. This allows a selection to determine if a date is included.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba left review comments

@amcdnl amcdnl Awaiting requested review from amcdnl

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
Date range picker
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roboshoes @googlebot @mmalerba